Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tech debt: Move experimental/nullable #32224

Merged
merged 15 commits into from
Jun 26, 2023
Merged

Tech debt: Move experimental/nullable #32224

merged 15 commits into from
Jun 26, 2023

Conversation

ewbankkit
Copy link
Contributor

Description

The internal/experimental/nullable package is successfully used by an increasing number of resource. This PR moves the package to internal/types/nullable.

Relations

Closes #27863.

@ewbankkit
Move 'internal/experimental/nullable' to 'internal/types/nullable'.
e574359
@ewbankkit
internal/provider: 'internal/experimental/nullable' -> 'internal/type…
e6fc276 
…s/nullable'.
@ewbankkit
'internal/experimental/nullable' -> 'internal/types/nullable' - acces…
975ca93 
…sanalyzer.
@ewbankkit
'internal/experimental/nullable' -> 'internal/types/nullable' - apiga…
9e67dc6 
…teway.
@ewbankkit
'internal/experimental/nullable' -> 'internal/types/nullable' - appau…
09c8d69 
…toscaling.
@ewbankkit
'internal/experimental/nullable' -> 'internal/types/nullable' - autos…
b42ddc3 
…caling.
@ewbankkit
'internal/experimental/nullable' -> 'internal/types/nullable' - ec2.
fea5707
@ewbankkit
'internal/experimental/nullable' -> 'internal/types/nullable' - elast…
16da58a 
…icache.
@ewbankkit
'internal/experimental/nullable' -> 'internal/types/nullable' - elbv2.
5f48f84
@ewbankkit
'internal/experimental/nullable' -> 'internal/types/nullable' - evide…
d3f29a1 
…ntly.
@ewbankkit
'internal/experimental/nullable' -> 'internal/types/nullable' - image…
0951bb4 
…builder.
@ewbankkit
'internal/experimental/nullable' -> 'internal/types/nullable' - logs.
8fbc1b5
@ewbankkit
'internal/experimental/nullable' -> 'internal/types/nullable' - mq.
05819bc
@ewbankkit
'internal/experimental/nullable' -> 'internal/types/nullable' - s3.
4c869f7
@ewbankkit
'internal/experimental/nullable' -> 'internal/types/nullable' - stora…
8db547e 
…gegateway.
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added provider Pertains to the provider itself, rather than any interaction with AWS. service/accessanalyzer Issues and PRs that pertain to the accessanalyzer service. service/apigateway Issues and PRs that pertain to the apigateway service. service/appautoscaling Issues and PRs that pertain to the appautoscaling service. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/ec2 Issues and PRs that pertain to the ec2 service. service/elasticache Issues and PRs that pertain to the elasticache service. service/elbv2 Issues and PRs that pertain to the elbv2 service. service/evidently Issues and PRs that pertain to the evidently service. service/imagebuilder Issues and PRs that pertain to the imagebuilder service. service/logs Issues and PRs that pertain to the logs service. service/mq Issues and PRs that pertain to the mq service. service/s3 Issues and PRs that pertain to the s3 service. service/storagegateway Issues and PRs that pertain to the storagegateway service. labels Jun 26, 2023
@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/S Managed by automation to categorize the size of a PR. labels Jun 26, 2023
@ewbankkit ewbankkit merged commit a1a0703 into main Jun 26, 2023
@ewbankkit ewbankkit deleted the td-move-experimental/nullable branch June 26, 2023 21:09
@github-actions github-actions bot added this to the v5.6.0 milestone Jun 26, 2023
github-actions bot pushed a commit that referenced this pull request Jun 26, 2023
Update CHANGELOG.md for #32224
240c27b
@github-actions
Copy link

This functionality has been released in v5.6.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@DanielMSchmidt DanielMSchmidt mentioned this pull request Jul 11, 2023
Open
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
provider Pertains to the provider itself, rather than any interaction with AWS. service/accessanalyzer Issues and PRs that pertain to the accessanalyzer service. service/apigateway Issues and PRs that pertain to the apigateway service. service/appautoscaling Issues and PRs that pertain to the appautoscaling service. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/ec2 Issues and PRs that pertain to the ec2 service. service/elasticache Issues and PRs that pertain to the elasticache service. service/elbv2 Issues and PRs that pertain to the elbv2 service. service/evidently Issues and PRs that pertain to the evidently service. service/imagebuilder Issues and PRs that pertain to the imagebuilder service. service/logs Issues and PRs that pertain to the logs service. service/mq Issues and PRs that pertain to the mq service. service/s3 Issues and PRs that pertain to the s3 service. service/storagegateway Issues and PRs that pertain to the storagegateway service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.6.0
Development

Successfully merging this pull request may close these issues.

Tech debt: Graduate internal/experimental/nullable
1 participant
@ewbankkit